In the naming guidelines it’s clearly stated:
✗ DO NOT use underscores, hyphens, or any other non-alphanumeric characters.
They all seem to apply:
- Underscores for all private instance field names
- s_ for all private static field names
- t_ for all private thread static field names
Should the guideline docs be updated or those commits be reverted? I kinda like NOT having to use underscores all over, so I prefer the previous style better, for what it’s worth